Skip to content

Adding an if condition on a for tag is deprecated in Twig 2.10. #13594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2020
Merged

Adding an if condition on a for tag is deprecated in Twig 2.10. #13594

merged 1 commit into from
Apr 27, 2020

Conversation

BooleanType
Copy link
Contributor

I've got an error, running example from the docs. Here is the explanation: https://twig.symfony.com/doc/2.x/deprecated.html#tags
I propose to use a filter filter or an “if” condition inside the “for” body instead in this docs.

@javiereguiluz javiereguiluz added this to the 4.4 milestone Apr 27, 2020
@javiereguiluz
Adding an if condition on a for tag is deprecated in Twig 2.10.
ae6ae33 
I've got an error, running example from the docs. Here is the explanation: https://twig.symfony.com/doc/2.x/deprecated.html#tags
I propose to use a filter filter or an “if” condition inside the “for” body instead in this docs.
@javiereguiluz javiereguiluz changed the base branch from 5.0 to 4.4 April 27, 2020 07:57
@javiereguiluz javiereguiluz merged commit 1ce98c2 into symfony:4.4 Apr 27, 2020
@javiereguiluz
Copy link
Member

Thanks @BooleanType and congrats on your first Symfony Docs contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@BooleanType @javiereguiluz @xabbuh @carsonbot